MetaMask / MetaMask/metamask-extension

[Bug]: Hard Crash "invalid hex string"

Open
#37,447 2 comments 0 reactions 1 assignee Claimed by @bschorchit View on GitHub
Bugs---Low-Priority external-contributor INVALID-ISSUE-TEMPLATE regression-prod-13.4.0 Sev2-normal team-confirmations type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

**Describe the bug**

I assume someone incorrectly thought a string that starts with `"0x"` is a hex string.

**Expected behavior**

To work normally???

**Steps to reproduce**

1. Simulate any transaction that writes a string
2. Write the value `"0x z"`
3. Hardcrash

**Error messages or log output**

```shell
Message: invalid hex string (argument="value", value="0x z", code=INVALID_ARGUMENT, version=bytes/5.8.0)

Code: INVALID_ARGUMENT

Code: Error

Stack:

e.prototype.makeError@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-10.js:1:342644
e.prototype.throwError@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-10.js:1:342784
e.prototype.throwArgumentError@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-10.js:1:342861
y@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-10.js:1:106622
E@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/ui-10.js:1:153773
sa@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:59431
Ys@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:111331
Cu@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:98677
Iu@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:98605
Pu@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:98466
wu@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:95463
Yi/<@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:45359
r.unstable_runWithPriority@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:123741
Ki@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:45137
Yi@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:45307
Vi@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:45240
mu@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:92855
Ca@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/common-8.js:1:64715
l/<@moz-extension://c194f3e0-cae8-4ef5-81ab-ec9abf42bec8/ui-8.js:1:304451
```

**Detection stage**

In production (default)

**Version**

13.4.0

**Build type**

None

**Browser**

Firefox

**Operating system**

Windows

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.