MetaMask / MetaMask/metamask-extension
Fix flask e2e test for new send flow
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
**What is this about?**
Flask e2e test for new send flow has been skipped here:
https://github.com/MetaMask/metamask-extension/pull/36529/files#diff-dcf20014cc19b1daeb7c8658f8a298f5e0e5443bfedb2466623460fd173f7e0fR267
It depends on old confirmation and needs to be re-written.
**Stakeholder review needed before the work gets merged**
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open the referenced pull request diff and inspect the skipped Flask e2e test around line 267, then trace how the old confirmation is used. Rewrite the test for the new send flow and verify that the Flask e2e test passes without being skipped.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- flask, typescript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100