Test - Confirmations Integration Test Failing intermittently

Open

#36,108 opened on Sep 19, 2025 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-CI Bugs---Low-Priority INVALID-ISSUE-TEMPLATE team-confirmations

Dominant language: TypeScript
Stars: 13.2k
Forks: 5.6k
Avg merge: 2d 5h
Merged PRs (30d): 451

Description

**What is this about?**

Multiple Confirmations Integrations tests failed (see [here](https://github.com/MetaMask/metamask-extension/actions/runs/17847749041/job/50750926119) for logs).

Failing tests:
- FAIL `test/integration/confirmations/transactions/erc20-approve.test.tsx`
- ERC20 Approve Confirmation › displays approve details with correct data
- FAIL `test/integration/confirmations/transactions/alerts.test.tsx`
- Contract Interaction Confirmation Alerts › displays the alert when gas estimate fails
- FAIL `test/integration/confirmations/transactions/alerts.test.tsx`
- Contract Interaction Confirmation Alerts › displays the alert when gas estimate fails
- FAIL `test/integration/confirmations/transactions/increase-allowance.test.tsx`
- ERC20 increaseAllowance Confirmation › displays approve details with correct data
- ERC20 increaseAllowance Confirmation › displays the advanced transaction details section
- FAIL `test/integration/confirmations/transactions/erc721-approve.test.tsx`
- ERC721 Approve Confirmation › displays approve details with correct data
- ERC721 Approve Confirmation › displays the advanced transaction details section

**Stakeholder review needed before the work gets merged**

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start with the linked GitHub Actions run and compare its logs with the failing tests in test/integration/confirmations/transactions/. Read erc20-approve.test.tsx, alerts.test.tsx, increase-allowance.test.tsx, and erc721-approve.test.tsx to identify the intermittent condition. Done means the listed confirmation tests pass reliably in integration runs.

Written by the indexing model from the issue text.

Assessment

Tech stack: typescript
Domain: testing-qa
Issue type: Bug
Difficulty: 4/5
Estimated time: 3-5 days
Activity status: Stale
Clarity: Mostly clear
Newbie friendliness: 35/100