MetaMask / MetaMask/metamask-extension
[Bug]: ENS resolution - Ipfs resolves domains before I've onboarded to the wallet
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### Describe the bug
Ipfs resolves domains before I've onboarded to the wallet or accepted terms and conditions
### Expected behavior
We should only start resolving ENS domains, once the user has Accepted Terms and conditions and has onboarded to the wallet (having the chance to disable this feature from settings before completing the onboarding)
### Screenshots/Recordings
https://github.com/user-attachments/assets/d52795c8-3854-4ec2-bed6-2ea9ba739a90
### Steps to reproduce
1. Install MetaMask for the first time
2. Without onboarding or accepting terms and conditions, open a new browser tab
3. Enter this `http://vitalik.eth`
4. See ENS resolves
### Error messages or log output
```shell
```
### Detection stage
In production (default)
### Version
13.1.0
### Build type
None
### Browser
Firefox, Chrome
### Operating system
Linux
### Hardware wallet
_No response_
### Additional context
_No response_
### Severity
_No response_
Contributor guide
Research direction
Start by reproducing the ENS resolution flow described in the issue on a fresh installation, before onboarding or accepting the terms. Trace the browser-extension entry point that resolves ENS domains and identify how onboarding, terms acceptance, and the settings opt-out affect it; done means `vitalik.eth` is not resolved until the required conditions are met.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100