MetaMask / MetaMask/metamask-extension
feat: Improve qr hardware wallet swap signing experience
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### What is this about?
when user is performing a swap while using a QR hardware wallet, they are asked to sign many times without clear messaging as to why. compared to other wallets like Rabby or Phantom who tell the user why they are signing.
[metamask-hw-wallet (1).pdf](https://github.com/user-attachments/files/21782488/metamask-hw-wallet.1.pdf)
### Scenario
- Given a user is using a qr hardware wallet like a keystone or airgap
- User tries to perform a swap
- two signatures with little information about what the user is signing should pop up
-
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
Research direction
Start by reviewing the swap scenario and the attached hardware-wallet PDF to understand the current signing prompts for Keystone or Airgap users. Clarify the intended signing messages, flow, and acceptance criteria with product and design before locating the implementation. Done means users understand why each signature is requested during a QR hardware-wallet swap.
Written by the indexing model from the issue text.
Assessment
- Domain
- blockchain, frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100