MetaMask / MetaMask/metamask-extension

Prevent send if no remaining allowance available

Open
#33,154 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

- On send screen, update the send allowance banner to show updated allowance available for user
- Check this function: https://github.com/MetaMask/delegation-framework/blob/0018e694d7a9ac2cb5435ff0e0ac05930cc40063/src/enforcers/MultiTokenPeriodEnforcer.sol#L100
- Check this test file: https://github.com/MetaMask/delegation-framework/blob/main/test/enforcers/MultiTokenPeriodEnforcer.t.sol

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the referenced MultiTokenPeriodEnforcer.sol function and test/enforcers/MultiTokenPeriodEnforcer.t.sol, then trace how the MetaMask send screen displays the allowance banner. Done means the banner shows the updated remaining allowance and sending is prevented when no allowance remains; the issue does not name the extension files or provide acceptance criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
solidity, typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.