MetaMask / MetaMask/metamask-extension

Vault Recovery - Setup event errors when vault is corrupted

Open
#33,103 0 comments 0 reactions 0 assignees View on GitHub
needs-triage team-extension-platform
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

Setup event errors when vault is corrupted if the user enables MetaMetrics after recover.
TDB.
From Mark: events can be queued and fired after (if) the user consents the MetaMetrics.

Relates to this PR from David: https://github.com/MetaMask/metamask-extension/pull/32006

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the referenced PR #32006, then trace setup events after vault recovery when MetaMetrics is enabled. Clarify how events should be queued and fired after consent, and define done as recovery from a corrupted vault no longer producing setup event errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
analytics, security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.