MetaMask / MetaMask/metamask-extension
[Feat]: Ambiguous behavior when attempting to connect with a Solana dapp with all Sol accounts hidden
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### Describe the bug
Expected behavior is a bit unclear for the scenario where a user has hidden all their Solana accounts but attempts to connect with a Solana dapp.
### Expected behavior
TBD
We might expect the user to have to explicitly unhide a Solana account before it can be selected and shared with the requesting dapp.
### Screenshots/Recordings
https://github.com/user-attachments/assets/1fb25019-9945-465a-9316-260f4cb41b9f
### Steps to reproduce
1. Hide all Solana accounts
2. attempt to connect with a Solana dapp
Current behavior:
- See that one of the hidden Solana accounts is picked as default
- When choosing to edit accounts during dapp connection, see that the Solana accounts become unhidden
### Error messages or log output
```shell
```
### Detection stage
During release testing
### Version
12.18.0
### Build type
Other (please specify exactly where you obtained this build in "Additional Context" section)
### Browser
Chrome
### Operating system
MacOS
### Hardware wallet
_No response_
### Additional context
Produced in the latest RC build
release-candidate build from git id: 7eb90e00
### Severity
low severity because most users will not hide all their Solana accounts. It's more of a question of the intended UX for this scenario.
Contributor guide
Research direction
Start with the listed reproduction steps in Chrome on macOS using the release-candidate build, hiding all Solana accounts before connecting to a Solana dapp. Review the attached recording and clarify the intended UX with maintainers; done means the all-hidden-account behavior is agreed and verified, including account selection and visibility changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100