MetaMask / MetaMask/metamask-extension
[Typescript-eslint] Fix `@typescript-eslint/no-floating-promises` violations
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### What is this about?
Fix all errors with `// eslint-disable-next-line @typescript-eslint/no-floating-promises`
Reference: https://typescript-eslint.io/rules/no-floating-promises/
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
Research direction
Search the repository for `// eslint-disable-next-line @typescript-eslint/no-floating-promises` and inspect each suppressed call. Read the `@typescript-eslint/no-floating-promises` rule documentation to determine the required handling, then run the relevant lint checks. Done means all identified violations are addressed without those suppressions remaining.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100