MetaMask / MetaMask/metamask-extension

[Typescript Conversion: Level 20]: Convert ui/components/ui/button/button.component.js to typescript

Open
#31,787 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

INVALID-ISSUE-TEMPLATE team-extension-platform
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

## **Description**

Convert `ui/components/ui/button/button.component.js` from JavaScript to TypeScript as part of the TS migration initiative.

## **Scenario (for user stories only)**

_(Not applicable)_

## **Design (for user stories only)**

_(Not applicable)_

## **Technical Details (for technical tasks only)**

- Convert this file to TypeScript.
- Migration Level: **20**
- Dependencies:
- None
- Dependents:
- ui/components/app/modals/new-account-modal/new-account-modal.component.js
- ui/components/ui/button/index.js
- ui/pages/settings/contact-list-tab/edit-contact/edit-contact.component.js
- ui/pages/settings/contact-list-tab/view-contact/view-contact.component.js

## **[Threat Modeling Framework](https://github.com/adamshostack/4QuestionFrame) (for technical tasks only)**

- What are we working on? Convert file to TypeScript.
- What can go wrong? Type errors, integration mismatches, missing types.
- What are we going to do about it? Write types carefully and test thoroughly.
- Did we do a good job? _(To be evaluated)_

## **Acceptance Criteria**

- File is fully converted to TypeScript.
- Tests pass.
- File adheres to linting rules.
- Functionality remains unchanged.

## **Stakeholder Review (for MetaMask employees only)**

- [X] Engineering
- [ ] Design
- [ ] Product
- [ ] QA
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management
- [ ] Other

## **References**

- Parent issue: #31460

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ui/components/ui/button/button.component.js and review its listed dependents: new-account-modal.component.js, index.js, and the contact views and editor. Convert the target file to TypeScript without changing functionality, then run the relevant tests and lint checks; done means the file is fully converted and both checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
frontend
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.