MetaMask / MetaMask/metamask-extension
[e2e] Different OS ends ups with slightly different funds amount representation
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### What is this about?
When running swap tests with Anvil, the final funds result differs based on the OS. So the test is stable in local but when running in another OS the results in funds changes slightly (like by 0.00001 ETH). We don't know why this is happening, hence this ticket. To investigate the reason and find a solution / answer to this behaviour.
More context, conversation in GH:
https://github.com/MetaMask/metamask-extension/pull/31278#discussion_r2013598586
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the swap tests with Anvil on the affected operating systems and compare the final funds values. Read the discussion linked from PR #31278 for existing investigation context. Done means identifying the cause of the OS-dependent difference and documenting or implementing a solution that makes the result stable across operating systems.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100