MetaMask / MetaMask/metamask-extension

[e2e] Manually generated token ask for confirmation when swap

Open
#31,426 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

For an unknown reason, the test in spec `test/e2e/tests/swaps/swap-erc20-with-loaded-state.spec.ts`, case `should swap ETH to WETH` is warning about manual token addition. We need to investigate this further, hence this ticket

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by running the case `should swap ETH to WETH` in `test/e2e/tests/swaps/swap-erc20-with-loaded-state.spec.ts` and observe when the manual token addition warning appears. Trace the warning from that scenario to determine why it is triggered; the issue provides no acceptance criteria beyond investigating the unexpected confirmation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.