MetaMask / MetaMask/metamask-extension

Apply min-width to the confirmation pages

Open
#31,060 0 comments 0 reactions 0 assignees View on GitHub
area-design Confirmations external-contributor INVALID-ISSUE-TEMPLATE needs-design team-confirmations team-design-system
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

**What is this about?**

[Needs design confirmation] reconsider min-width

Following the work to align responsiveness across various confirmation pages, we'd like to add a min-width of either 320px (standard min-width device support) or 400px (default popup width).

Centering of confirmations needs refactor since shrinking causes overflow on both left and right. In these cases, the overflow: auto does not trigger auto scrolling.

Spec:
- Send
- Redesign Confirmation Pages
- Install Snap flow
- Various Snap pages (See https://metamask.github.io/snap-simple-keyring/latest/ using flask mode)
- Account (Dapp) Permissions

**less than min-width 320px**






**Stakeholder review needed before the work gets merged**

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

Contributor guide

Open the contributing guide

Research direction

Start by locating the confirmation-page implementations for Send, Redesign Confirmation Pages, Install Snap, the listed Snap pages, and Account (Dapp) Permissions. Confirm with design whether the minimum width is 320px or 400px, then verify centering and overflow behavior below that width; done requires stakeholder review before merge.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
design, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.