MetaMask / MetaMask/metamask-extension
[Bug]: Incorrect message when disabling Profile Sync, as Notifications is no longer dependent on Profile Sync toggle
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### Describe the bug
When disabling Profile sync from settings, a message appears that Notifications won't be received anymore.
Since `Notifications` is no longer dependent on `Profile Sync` toggle, then the message should be updated
Currently: Disabling `Profile sync` does not disable `Notifications`
### Expected behavior
Correct message to appear when disabling profile sync
### Screenshots/Recordings
https://github.com/user-attachments/assets/d6d2e3a0-8ba1-41d6-9a4c-21ea7838b227

### Steps to reproduce
1. Go to Settings `Security & privacy`
2. Turn OFF Profile Sync
3. Notice message regarding disabling notifications
3. Click on the 3 dots and `Notifications` or go to Settings `Notifications`
4. Notice `Notifications` are still enabled
### Error messages or log output
```shell
```
### Detection stage
During release testing
### Version
12.14.0
### Build type
None
### Browser
Chrome, Firefox
### Operating system
MacOS
### Hardware wallet
_No response_
### Additional context
_No response_
### Severity
_No response_
Contributor guide
Research direction
Reproduce the Settings > Security & privacy flow by turning off Profile Sync, then search the frontend for the warning text shown in the issue. Update the message so it no longer claims Notifications will be disabled, and verify that Notifications remain enabled after the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100