MetaMask / MetaMask/metamask-extension

Approvals to contracts unknown to Blockaid blanket appear as "Deceptive Request"

Open
#30,960 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

external-contributor
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

What is this about?

I'm with https://drips.network, and we're about to launch a campaign with Web3Privacy Now for donations to a bunch of privacy-focussed projects. We just noticed that MetaMask displays a very intense warning when making a donation during the ERC-20 approval transaction:

Image

Our approvals are only for the necessary amount, and our contract is definitely not deceptive or "known for scams".

It looks as if this warning appears on an approval request to every contract that is unknown / unclassified on Blockaid.

I already submitted a "false positive" report to Blockaid directly, however I think that this warning should not confidently state "This is a deceptive request" unless Blockaid has explicit reason to classify it as such, which does not appear to be the case here. The wording is too strong for the case when Blockaid simply hasn't explicitly marked the recipient contract as "trusted".

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged
  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)
References

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue provides no file, test, or entry point. Start by reproducing the ERC-20 approval donation flow in the MetaMask extension and inspect how Blockaid's classification becomes the displayed warning. Done means unknown or unclassified contracts no longer receive the confident "Deceptive Request" wording without an explicit deceptive classification.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, security
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.