MetaMask / MetaMask/metamask-extension
[Cleanup]: update or remove useTypedSignSignatureInfo
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
**What is this about?**
I think this is confusing because it returns a simplified primaryType, order or permit, rather than it's exact primaryType that was provided in the request. It is also only used in one place: ConfirmTitle.
Maybe we could remove the hook and and/or update logic to either:
- directly check if primary type is an order or permit rather than check through coerced primaryType
- support a new concept like primaryTypeCategory or primaryTypeGroup
**Stakeholder review needed before the work gets merged**
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
Contributor guide
Research direction
Start by locating useTypedSignSignatureInfo and its sole use in ConfirmTitle, then trace how primaryType is coerced and which request values reach the hook. Clarify with engineering whether the hook should be removed or replaced with an explicit category concept; done means the chosen behavior is implemented with appropriate tests and stakeholder review.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100