MetaMask / MetaMask/metamask-extension

[Bug]: Onboarding - Authentication requests are sent before letting me disable the feature in Settings

Open
#30,357 0 comments 0 reactions 0 assignees View on GitHub
area-privacy regression-RC-12.13.0 Sev2-normal team-identity-deprecated type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

Whenever I am onboarding, when I am at the step of editing the Settings, I see how requests to the Authentication API are already sent, before I have the chance to disable the Profile Sync feature.

This happens in 12.13 but not in 12.12

### Expected behavior

We should not sent any external API requests until the Settings are edited, after onboarding

### Screenshots/Recordings

https://github.com/user-attachments/assets/167ebcf0-660e-4360-86e4-ac92b7269ed5

### Steps to reproduce

1. Start the onboarding
2. Click Edit Default Settings
3. See how requests to the authentication API Are already made before you disabling the feature

### Error messages or log output

```shell

```

### Detection stage

During release testing

### Version

12.13.0

### Build type

None

### Browser

Chrome

### Operating system

Linux

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the onboarding flow in Chrome: open Edit Default Settings and observe when Authentication API requests are sent. Trace the onboarding and Settings flow to identify why requests occur before the Profile Sync feature can be disabled; done means no external API requests are sent until after Settings are edited.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.