MetaMask / MetaMask/metamask-extension
Add quality gate to prevent additional base 64 encoded pngs inside SVGs
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### What is this about?
- SVG (png base 64 encoded inside of SVG). Problem with this is that SVG is a compressible file type but base 64 encoded is not) so the webpack zip process runs out of memory. We have another issue that handles removing these and once we remove them we need to add a quality gate so more can't be added
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
Research direction
The issue identifies embedded base64 PNGs in SVGs and the webpack zip process as the affected areas, but names no files, tests, or entry points. Start by locating the related work that removes existing images and the webpack packaging configuration; done should include a quality gate that rejects new embedded PNGs and verifies the packaging remains safe.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- webpack
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100