MetaMask / MetaMask/metamask-extension

Add quality gate that would block on increasing peer dependency warnings

Open
#28,968 0 comments 0 reactions 1 assignee Claimed by @mikesposito View on GitHub
external-contributor team-core-platform
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

Add quality gate that would block on increasing peer dependency warnings. If this is doable in yarn at the local dev point we should do it there.
AKA: We can switch to having the yarn warnings from warnings to errors around peer dependencies. Breaks on yarn install. There is a way to disable peer dependencies. -- Maybe this is possible with yarn plugin, we might have to roll our own solution here. Align this for both Mobile and Extension. Which ever path we go we should do the same for the other client.

Otherwise lets do this via CI.

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [X] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.