MetaMask / MetaMask/metamask-extension

Multichain: Update Controllers to Remove NetworkController getState dependencies

Open
#28,094 0 comments 0 reactions 0 assignees View on GitHub
multichain-final-boss
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

A number of controllers in `core` repo use `NetworkController:getState` and likewise calls to get the currently selected global chain ID. We need to remove or shim this reliance as there will no longer be a globally selected chain ID.

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

No files or tests are identified. Start by locating controllers in the core repository that call NetworkController:getState or read the currently selected global chain ID, then trace how those dependencies are used. Done means the controllers no longer rely on a globally selected chain ID, using removal or a shim as appropriate.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.