MetaMask / MetaMask/metamask-extension
Multichain: Consolidate Network Switching in E2Es to Make
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### What is this about?
In an effort to make removal of the NetworkPicker from the UI (https://github.com/MetaMask/metamask-extension/issues/27836) header break less tests, we should consolidate all usages of the NetworkPicker in E2Es into one function, called everywhere, so that we'll only need to adjust that function when we remove the NetworkPicker.
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
Research direction
Search the E2E tests for every use of the NetworkPicker and compare the existing network-switching flows. Introduce one shared switching function and update all those usages to call it, then verify the E2E suite passes and that future NetworkPicker removal requires changing only that function.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100