MetaMask / MetaMask/metamask-extension

Clean-up unnecessary getters for state properties

Open
#27,451 0 comments 0 reactions 0 assignees View on GitHub
external-contributor team-core-platform
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

The PreferencesController has unnecessary getters which could also be accessed from state property of the controller. For example `getUseRequestQueue() `, which could also be accessed as state.useRequestQueue. We need to remove all the getters/state properties duplication. And also not to entertain setters where messaging can be used to update the state.

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [X] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating PreferencesController and the getUseRequestQueue() getter, then inventory the other duplicated state getters and setters. Confirm each property can be read from controller state or updated through messaging, remove the redundant accessors, and verify the controller no longer exposes duplicated state APIs.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.