MetaMask / MetaMask/metamask-extension

[Bug]: Notifications - Notification details do not show accurate gas information for networks with L1 and L2 gas split

Open
#26,892 2 comments 0 reactions 0 assignees View on GitHub
regression-prod-12.1.1 Sev2-normal team-notifications-deprecated type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

When checking the notification details for transactions that happened in networks where there is gas payed in both L1 and L2 (ie Optimism), the gas details do not show this split and it's not clear which values are they showing (either L1 or L2).

I think we want a gas split information in the same was as we do for transactions, where we show gas for L1 and L2.

### Expected behavior

_No response_

### Screenshots/Recordings

On the left side, gas details not split up, so we don't know to what they refer.
On the right side, gas details split up for that specific tx, in Etherscan
![Screenshot from 2024-09-04 12-31-13](https://github.com/user-attachments/assets/1b040855-0971-4fca-a6d1-3460ee98be22)

### Steps to reproduce

1. Enable notifications
2. Send a tx in Optimism
3. Check gas split in the confirmation page
4. Confirm
5. Now check the notification
6. Check gas details
7. See there is no gas split between L1 and L2

### Error messages or log output

_No response_

### Detection stage

In production (default)

### Version

12.1.1

### Build type

None

### Browser

Chrome

### Operating system

Linux

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue using the listed steps with notifications enabled and a transaction on Optimism. Compare the notification’s gas details with the transaction confirmation page, focusing on whether L1 and L2 values are both represented. Done means the notification clearly distinguishes the two gas amounts, with coverage for the affected flow if the repository provides relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.