MetaMask / MetaMask/metamask-extension

[Bug]: Contact names should not allow duplication

Open
#26,621 0 comments 1 reaction 1 assignee Claimed by @Matt561 View on GitHub
INVALID-ISSUE-TEMPLATE Sev2-normal team-identity-deprecated type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug:

When adding a new contact, there is no verification is the name collides with an existing contact, nor with existing local accounts:

### Expected behavior

Adding a new contact with the same name as an existing contact, or with one of the reserved account names should be disallowed, unless the address also matches.

### Screenshots/Recordings

![Image](https://github.com/user-attachments/assets/d9367b07-8db7-4541-a996-120098ecf007)

### Steps to reproduce

1. go to `Settings / Contacts`
2. click `Add Contact`
3. use the name of an existing contact but a different address
4. observe that there is no error when you click `Save`
5. observe that 2 contacts appear in your address book with the same name

### Environment

Browser: Brave (but probably all)
Build type: production
Version: 12 (but the issue is older)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.