MetaMask / MetaMask/metamask-extension

[Bug]: Notifications do not appear on the MetaMask badge; when a user toggles any of the notification settings on and off, there seems to be a pause in notification delivery

Open
#26,359 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

regression-prod-12.0.1 Sev2-normal team-notifications-deprecated type-bug
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

1. Notifications appear only within the MetaMask tab or popup, but not on the MM badge - not sure if that's expected.
2. When a user toggles any of the notification settings on and off, there seems to be a pause in notification delivery. Notifications resume once the user navigates to Notifications -> Settings, they then appear exclusively within the MetaMask tab or popup.

### Expected behavior

-

### Screenshots/Recordings

Chrome:

https://github.com/user-attachments/assets/cdec85cd-626e-4558-8aa1-f12b45ed739d

Firefox:

https://github.com/user-attachments/assets/aaa93420-4f4a-4a92-86cf-5c27a1d68b1d

Screenshot 2024-08-09 at 17 51 49

Screenshot 2024-08-09 at 17 46 28

### Steps to reproduce

1. Go to Notifications -> Settings, disable / enbale any of the toggles for Chrome (for Firefox you don't need to ON/OFF toggles, notifications do not show up after enabling them)
2. Send a transaction (-s)
3. Notification doesn't appear
4. Go back to Notifications -> Settings
5. Notifications for the sent transactions displayed

### Error messages or log output

_No response_

### Detection stage

In production (default)

### Version

12.1.0

### Build type

None

### Browser

Chrome, Firefox

### Operating system

MacOS

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Chrome and Firefox steps in Notifications → Settings, including sending a transaction after changing notification toggles. Compare badge delivery with notifications shown in the MetaMask tab or popup, and consider the issue resolved when notifications appear without reopening Settings after a toggle change.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.