MetaMask / MetaMask/metamask-extension

Update crowdin action to include ability to manually trigger a translation pull

Open
#26,334 0 comments 0 reactions 1 assignee View on GitHub

@desi is already working on this.

Since Aug 2, 2024.

area-translation team-extension-platform
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

Sometimes we have situations where translations are not correct. We are generally able to get our translation partner to correct these rather quickly however, since our crowdin action only runs once every 12 hours we have to wait until the next run in order to get the updates.

We'd like to add the ability to manually trigger the action when needed.

### Scenario

- Given I am a MM developer
- And I have available translations that I can get from crowdin
- And I manually trigger the crowdin action
- Then a new PR is created (or an existing one is updated) to get the new translations on demand

### Design

n/a

### Technical Details

Add `workflow_dispatch` above `schedule:` in [Crowdin Action ](https://github.com/MetaMask/metamask-extension/blob/e5651cfe3580db9ed49a31b3b6fe6e00f1b9b47e/.github/workflows/crowdin-action.yml#L11)

### Threat Modeling Framework

_No response_

### Acceptance Criteria

Acceptance Criteria
- [Go to github action](https://github.com/MetaMask/metamask-extension/actions/workflows/crowdin-action.yml)
- Click on "run workflow"
Screenshot 2024-08-02 at 1 52 41 PM
- This is working correctly if you can even see the button above

### Stakeholder review needed before the work gets merged

- [X] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.