MetaMask / MetaMask/metamask-extension
Clean up community contributed locales to remove redundancies
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### What is this about?
We currently have 57 locale files. 14 of these are supported by our translations partner and the rest are community supported. We currently have a couple of locales which are redundant.
- hn
-- this is not an actual language code
-- the translations appear to be Hindi and should be moved into the Hindi locale
- ph
-- these 1759 lines of code are in Tagalog, but ph is not a recognized locale code. Someone is actively contributing to this locale, but it is likely creating confusion because right now extension lists three different locales for the same language "Filipino (fil), Pilipino (ph), Wikang Tagalog (tl)". Wikang Tagalog "tl" is the locale that is supported by our translation team
-- we should determine what next steps are with regard to these 3 and combine/correct them.
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [X] Engineering (needed in most cases)
- [ ] Design
- [X] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
Research direction
Inspect the locale files for hn, ph, hi, fil, and tl, comparing their language content and recognized locale codes. Confirm the desired consolidation with engineering and product before changing anything; done means redundant locales are removed or merged without losing translations and the extension no longer lists overlapping locales.
Written by the indexing model from the issue text.
Assessment
- Domain
- localization
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100