MetaMask / MetaMask/metamask-extension

Move `wallet_registerOnboarding` implementation to method middleware

Open
#24,471 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area-api INVALID-ISSUE-TEMPLATE
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

Our implementation of `wallet_registerOnboarding` currently lives in its own middleware function. The implementation should be moved to the method middleware instead along with all the other unrestricted RPC methods.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the wallet_registerOnboarding middleware function and the method middleware that handles unrestricted RPC methods. Compare the surrounding implementations and move wallet_registerOnboarding into the method middleware without changing its behavior. Done means the implementation is no longer in its standalone middleware and is handled with the other unrestricted RPC methods.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, backend-api-design
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.