MetaMask / MetaMask/metamask-extension
[Sentry] Error: Previous transaction is already confirmed
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
Sentry Issue: [METAMASK-X9TT](https://metamask.sentry.io/issues/5200732193/?referrer=github_integration)
```
Error: Previous transaction is already confirmed
at MetamaskController.createSpeedUpTransaction (app/scripts/metamask-controller.js:4147:33)
at async s. (app/scripts/lib/createMetaRPCHandler.js:23:7)
```
Comment: This seems to happen due to a race condition where user tries to speed up a transaction, while transaction already got validated in the meanwhile. This error is currently unhandled and should be handled.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at app/scripts/metamask-controller.js:4147 and inspect MetamaskController.createSpeedUpTransaction, then read the call through app/scripts/lib/createMetaRPCHandler.js:23. Confirm how the race between speeding up and confirmation is surfaced, and make the already-confirmed case handled rather than producing an unhandled error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100