MetaMask / MetaMask/metamask-extension
[Proposal]: Display resolved ENS name instead of account name
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### Describe the bug
Testing with v11.14.1 with Chrome 117.0.5938.92 in Mac Sonoma 14.3.1.
I was unsure if it was an issue with [an older ERC721 ENS name](https://app.ens.domains/metarnask.eth), so I [registered a fresh ERC1155](https://app.ens.domains/rnetamask.eth) today and refreshed the extension and the HD account name remains `Account 2`. Also not working as I expect on both Ledger and QR hardware wallets.
I went back to v11.10.1 and can also observe the same behavior, so maybe this has been broken for awhile but I see no gh issue for this.
### Expected behavior
I am expecting that an ENS name replaces the account name, when the public address reverse resolves to an ENS name.
### Screenshots/Recordings
[Recording of new ENS reservation](https://www.loom.com/share/50329319562c44d798262ad00602cc16?sid=b9cf6011-e6ac-4097-8065-12c8f4c73e2a) of reserving a new ENS name on mainnet
### Steps to reproduce
If you already have the address in test that reverse resolves to an ENS name:
1. Have an ENS name on the account
2. Go to Settings>Privacy & security
3. Scroll down
4. have the default setting of ON for `Show ENS domains in address bar`
5. Tap the toggle to turn ON `Autodetect NFTs'
6. Note that `Display NFT media` will also turn ON
7. Check account list and note that ENS name is not showing
8. Tap to open `NFTs` tab and note that ENS name should be present (_**if owned**_)
9. Reload extension at `chrome://extensions/`
10. Open extension
11. Authenticate
12. Note that ENS name still does not show in account list even when NFT is present
Or Register a new name (as recorded):
1. Have an account with mainnet Eth
2. Go to Settings>Privacy & security
3. Scroll down
4. have the default setting of ON for `Show ENS domains in address bar`
5. Tap the toggle to turn ON `Display NFT media`
6. Tap the toggle to turn ON `Autodetect NFTs'
7. visit app.ens.domains and find a name
8. Connect dapp to wallet and confirm
9. Initiate timer transaction and sign
10. wait 60 seconds
11. Initiate reservation
13. sign and broadcast
14. Reload extension
15. Open extension
16. Authenticate
17. Tap to open `NFTs` tab and note that ENS name should be present
18. Note that ENS name still does not show in account list even when NFT is present
### Error messages or log output
_No response_
### Version
11.10.1
### Build type
None
### Browser
Chrome
### Operating system
MacOS
### Hardware wallet
Ledger, Keystone
### Additional context
Impacting HD as well as Hardware accounts
### Severity
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the account-list behavior in Chrome with an address that reverse resolves to an ENS name, following the listed Privacy & security and reload steps. Trace how the account list differs from the NFTs tab for HD and hardware accounts; done means the resolved ENS name appears in the account list when available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100