MetaMask / MetaMask/metamask-extension
Remove `setApproveForAll` references from TokenAllowance and ApproveContentCard
Open
Nobody has claimed this yet.
Confirmation-Architecture
INVALID-ISSUE-TEMPLATE
team-confirmations
team-confirmations-secure-ux-deprecated
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
See comment for more context: https://github.com/MetaMask/metamask-extension/pull/23897/files#r1558002528
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the TokenAllowance and ApproveContentCard implementations and the linked pull-request comment for the missing context. Determine which setApproveForAll references are in scope, then verify that those references are removed without affecting the components' remaining behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100