MetaMask / MetaMask/metamask-extension

[Confirmations] Redesign - Signature Screens

Open
#23,683 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

### 1. Favicon has been removed
Favicon is not displayed. Should we consider displaying it or is it intentionally removed from the new re-design screens? See left side re-design, right side current production
cc @bschorchit @SayaGT

![Screenshot from 2024-03-25 09-29-27](https://github.com/MetaMask/metamask-extension/assets/54408225/557f1f63-b190-4802-9cdd-551b0bd7641e)

### 2. Link to Etherscan has been removed
There is no link to Etherscan anymore for the verifying contract. See left side re-design, right side current production

Issue here https://github.com/MetaMask/MetaMask-planning/issues/2289

![Screenshot from 2024-03-25 09-28-58](https://github.com/MetaMask/metamask-extension/assets/54408225/86ccfca3-719b-4c67-82a4-68a7e1713796)

### 3. Signatures Navigation problems when mixing with Transactions

https://github.com/MetaMask/metamask-extension/issues/23692

### 4. Reverse String not properly Handled
https://github.com/MetaMask/metamask-extension/issues/23691

### 5. Blockaid styling in settings should be updated and warnings not displayed
https://github.com/MetaMask/metamask-extension/issues/23684
:red_circle: Important note: this also happens with develop builds without re-design enabled, meaning this would land in the next RC if not fixed

Furthermore, we don't see Blockaid warnings in Signatures (I think that's expected since notification task is pending?) cc @bschorchit

### 6. Account Balance displays incorrect currency

https://github.com/MetaMask/metamask-extension/issues/23690

### 7. Network Name not correct
https://github.com/MetaMask/metamask-extension/issues/23686

### 8. Sign Typed Data not using Re-design components
https://github.com/MetaMask/metamask-extension/issues/23688

### 9. Not able to Sign with a Hardware Wallet and HW warning missing
https://github.com/MetaMask/metamask-extension/issues/23687
There is also the warning missing, should this be fixed with the Notifications work? cc @bschorchit

### 10. Malformed Signatures broken
All the issues we currently have in prod, are also reproduceable with the new re-design screens. Do we aim to tackle those with the re-design or is this out of scope? cc @bschorchit @cryptotavares

- [[Bug]: Signatures - Verify 3rd party details disappears if an empty domain is passed on a Typed Signature 3 & 4](https://github.com/MetaMask/metamask-extension/issues/21011)
- [[Bug]: Signatures - MetaMask breaks with the error Invalid primary type definition](https://github.com/MetaMask/metamask-extension/issues/22899)
- [[Bug]: Signatures - MetaMask breaks with error msg.map is not a function when passing an invalid type](https://github.com/MetaMask/metamask-extension/issues/22525)
- [[Bug]: Signatures - Passing extra data not typed is added in the signature but not visible on the UI](https://github.com/MetaMask/metamask-extension/issues/22900)
- [[Bug]: Signatures - MetaMask breaks with TypeError: text.slice is not a function when passing invalid verifyingContract](https://github.com/MetaMask/metamask-extension/issues/22901)

### 11. Signature message is not correct
https://github.com/MetaMask/metamask-extension/issues/23689

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Start by reviewing linked issues 23684, 23686–23692 and the listed malformed-signature issues, then confirm the intended redesign scope and acceptance criteria before implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
15/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.