MetaMask / MetaMask/metamask-extension
chore: Bump `@metamask/eslint-config-typescript` to latest
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### What is this about?
## Motivation
Currently, the ESLint config packages are approximately ~3 years~ ~4 years~ 5 years out of date (as of ~Jan 2025~ Jul 2026).
Out of these, upgrading the `@metamask/eslint-config-typescript` configuration needs to be prioritized due to the ongoing TypeScript conversion efforts. There are a number of breaking changes in the intervening versions that should be applied to incoming TypeScript code as they encourage important best practices.
The number of errors that need to be fixed in order to make this update work is already significant. Postponing this task further will only worsen this problem.
## Requirements
1. For rules that are auto-fixable or have applicable suggestions, resolve errors/warnings in the same PR.
2. For some rules, it may be important to ensure that new violations are not introduced into the codebase, but fixing the existing violations is lower priority or too high-effort. In such cases, mark existing violations with an `eslint-disable` directive and TODO comment.
3. Disable non-auto fixable rules in the ESLint config file with a comment indicating that they should be re-enabled.
4. Write tickets for re-enabling these rules.
5. (Write tickets for bumping other ESLint packages in Extension).
## Status
Current violations for the up-to-date version of `@metamask/eslint-config-typescript`:
### Scenario
_No response_
### Design
_No response_
### Technical Details
_No response_
### Threat Modeling Framework
_No response_
### Acceptance Criteria
_No response_
### Stakeholder review needed before the work gets merged
- [x] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)
### References
_No response_
Contributor guide
Assessment
This issue has not been assessed yet.