MetaMask / MetaMask/metamask-extension
Add PetNames to `ConfirmInfoRowAddress` when snaps are installed
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
When we added support for PetNames on the component, we excluded snaps because the component assumes the chainId currently selected, and that may not be the network we want to save PetNames for.
For more info see this commit.
This ticket is about removing the isSnapInstalled variable and making the necessary changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ConfirmInfoRowAddress component and review commit 59b9354477ff1e316be3361f5b97512effe6d4b1 for the existing PetNames and snap handling. Trace the isSnapInstalled variable and its consumers, then verify that PetNames are handled when snaps are installed without relying on the currently selected chainId.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100