MetaMask / MetaMask/metamask-extension

Enhancement: Send ERC1155 Confirmation screen not capturing amount of tokens sent

Open
#22,555 0 comments 0 reactions 0 assignees View on GitHub
team-confirmations-planning
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

Whenever we are sending an ERC1155 token, on the Send Amount, we can specify the Token Id and the Amount. However, on the Confirmation screen, we don't see anywhere the amount of tokens we are sending - only the token Id

![Screenshot from 2024-01-17 14-52-45](https://github.com/MetaMask/metamask-extension/assets/54408225/57a7c75e-5661-4d1a-8b24-597ea73fed9f)

![Screenshot from 2024-01-17 14-52-27](https://github.com/MetaMask/metamask-extension/assets/54408225/561a9580-6094-49e5-8e40-c9b967f1397d)

### Scenario

_No response_

### Design

_No response_

### Technical Details

_No response_

### Threat Modeling Framework

_No response_

### Acceptance Criteria

_No response_

### Stakeholder review needed before the work gets merged

- [ ] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by tracing the ERC1155 Send Amount and Confirmation screens to find where the token ID is displayed and how the entered amount is carried forward. Verify the confirmation state for an ERC1155 transfer and add coverage if an existing test entry point is found. Done means the confirmation screen visibly shows both the token ID and amount being sent.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.