MetaMask / MetaMask/metamask-extension

Update Instances of ModalContent to Use New Padding and Scrolling Behavior

Open
#22,223 0 comments 3 reactions 1 assignee Claimed by @georgewrmarshall View on GitHub
team-design-system
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### What is this about?

Update all instances of the deprecated ModalContent to use the new ModalContent component with new padding and scrolling behavior, so that we can maintain consistency across the application and improve the user experience.

### Scenario

_No response_

### Design

_No response_

### Technical Details

- Identify all instances of deprecated ModalContent in the codebase.
- Update each instance to use the new ModalContent.
- Ensure that the updated ModalContent uses the new padding and scrolling behavior.

### Threat Modeling Framework

_No response_

### Acceptance Criteria

- All instances of ModalContent have been updated to use the new ModalContent.
- The updated ModalContent uses the new padding and scrolling behavior.
- The changes have been tested and verified in each instance where ModalContent is used.

### Stakeholder review needed before the work gets merged

- [X] Engineering (needed in most cases)
- [ ] Design
- [ ] Product
- [ ] QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
- [ ] Security
- [ ] Legal
- [ ] Marketing
- [ ] Management (please specify)
- [ ] Other (please specify)

### References

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.