MetaMask / MetaMask/metamask-extension
Fix onAccountRemoved sentry error
Open
INVALID-ISSUE-TEMPLATE
team-accounts-framework
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
When removing an account, `_onKeyringControllerUpdate` and `onAccountRemoval` to be fired. Both of these actions would call removeAddress on the preferences controller.
Contributor guide
Research direction
Start by tracing _onKeyringControllerUpdate and onAccountRemoval to see how both reach removeAddress on the preferences controller. Confirm the account-removal flow no longer triggers the duplicate action or the reported Sentry error, and add or update coverage if the relevant tests are found nearby.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100