MetaMask / MetaMask/metamask-extension
[Bug]: Contract data reading and parsing should not throw
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
- readAddressAsContract is incorrectly using a promise-style async call. EthQuery expects a callback.
- determineTransactionType is throwing "cannot read property 'name' of undefined" when trying to parse data. However, in the case of a simple send, data is always undefined.
Fix proposed and merged in https://github.com/MetaMask/metamask-extension/pull/21604
Contributor guide
Research direction
Review readAddressAsContract and determineTransactionType, then compare the reported behavior with the fix proposed and merged in pull request 21604. No implementation remains in this issue; completion would mean confirming that contract data reading and parsing no longer throws for simple sends.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 20/100