MetaMask / MetaMask/metamask-extension

[Feat]: Support i18n placeholder input in Storybook | Fix [object Object] translations

Open
#21,405 2 comments 0 reactions 1 assignee Claimed by @garrettbear View on GitHub
regression-prod-11.2.0 Sev3-low team-design-system
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

i18n placeholder input is not supported in Storybook which results in translations outputting "[Object object]" when placeholder inputs are provided. Supporting this feature will help us have a more accurate representation of the rendered components.

### Expected behavior

Current behavior:
Storybook TokenAllowance page displays "Spending cap behavior for [object Object]"

Expected behavior:
Storybook TokenAllowance page displays "Spending cap behavior for TST"

### Screenshots

Screenshot 2023-10-17 at 2 36 32 PM
Screenshot 2023-10-17 at 2 55 52 PM
Screenshot 2023-10-17 at 2 55 55 PM

### Steps to reproduce

1. run storybook `yarn storybook`
2. open a page that passes a second parameter to the `t`, translation function (placeholder input)
3. observe "[object Object]" displays instead of expected content

### Error messages or log output

_No response_

### Version

11.2.0

### Build type

None

### Browser

Chrome

### Operating system

MacOS

### Hardware wallet

_No response_

### Additional context

_No response_

### Severity

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.