MetaMask / MetaMask/metamask-extension

[Bug]: Ipfs gateway displayed in privacy setting page is confusing when user entered an invalid value

Open
#20,848 4 comments 0 reactions 1 assignee Claimed by @vinnyhoward View on GitHub
area-settings feature-request INVALID-ISSUE-TEMPLATE regression-RC regression-RC-11.1.0 release-11.1.0 team-core-extension-ux
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

**Describe the bug**

When user enter an invalid ipfs gateway on privacy setting page, there's message shows that the input is not valid. But when reopen the setting page, the invalide gateway still displayed and truncated.

**Steps to reproduce**

1. Go to privacy settings page
2. Add an invalid IPFS gateway "test test", see error message is displayed
3. Close setting page and land on home page
4. Go to privacy setting page again, see IPFS gateway is displayed as "test"

**Expected**
Either we cannot proceed with an invalid address, **or** when we reopen the settings page, the previous valid address is displayed.

https://github.com/MetaMask/metamask-extension/assets/105063779/49957d4e-4375-43e6-8f6b-0e4e39787a23

**Version**

v11.1.0

**Build type**

None

**Browser**

Chrome

**Operating system**

MacOS

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.