[Sentry] WARNING: `Translator - Unable to find value of key "${key}" for locale "${localeCode}"`,

Sentry warning: METAMASK-PVS3
Private Zenhub Image

Currently we will throw error when we have missing value for new added locale key, which happens all the time, because we will rely on such automation Crowdin MR from bot to help to merge the missing value, and there will always be a gap between production and current translated locales.

What we want to achieve is to not only removing warning from sentry report, but handle the error elegantly.

We can change the approach by make modifications in the log.warn we have at the moment in following helper function:

function missingKeyError(
  key: string,
  localeCode: string,
  onError?: (error: Error) => void,
) {
  if (localeCode === FALLBACK_LOCALE && !missingMessageErrors[key]) {
    const error = new Error(
      `Unable to find value of key "${key}" for locale "${localeCode}"`,
    );

    missingMessageErrors[key] = error;

    onError?.(error);
    log.error(error);

    if (process.env.IN_TEST) {
      throw error;
    }
  }

  if (localeCode === FALLBACK_LOCALE || warned[localeCode]?.[key]) {
    return;
  }

  warned[localeCode] = warned[localeCode] ?? {};
  warned[localeCode][key] = true;

// ----- we can return a new value/undefined here, 
  log.warn(
    `Translator - Unable to find value of key "${key}" for locale "${localeCode}"`,
  );
} 

Proposal:

1. Return en value when key is not found