MetaMask / MetaMask/metamask-extension

When there is no account, do not render buttons in connect hardware flow

Open
#19,202 1 comment 0 reactions 0 assignees View on GitHub
Sev3-low team-accounts-framework type-enhancement
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Describe the bug

If there is no account then the button should not be rendered.

This was a nit from https://github.com/MetaMask/metamask-extension/pull/17610. That incremental improvement has been merged, but we would still like to request that this be further enhanced.

### Steps to reproduce

From https://github.com/MetaMask/metamask-extension/issues/14896:

Steps to reproduce
1. Unlock Metamask
2. Unfold Menu
3. Click Connect Hardware Wallet
4. Click Ledger and wait

### Error messages or log output

_No response_

### Version

10.30.4

### Build type

None

### Browser

Chrome, Firefox

### Operating system

MacOS

### Hardware wallet

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Reproduce the listed connect hardware wallet flow, checking the Ledger screen when no account is available. Done means the buttons are not rendered in that state; the issue names no file or test, so locate the existing flow and its coverage before changing it.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.