MetaMask / MetaMask/metamask-extension

UI and copy fix for Set Approve for All Warning

Open
#18,591 5 comments 0 reactions 0 assignees View on GitHub
team-confirmations-planning
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

### Requirements

- Align Warning icon to the title
- Change color of warning icon from `icon-default` to `warning ` (orange)
- Add padding of 16px between Buttons
- Change copy of Secondary Button from "Reject to "Cancel"
- Change title to" your NFTs may be at risk"

Current build
![Screenshot 2023-04-14 at 13.42.33.png](https://images.zenhubusercontent.com/61ef00ec5db2d7c84498dc72/d2b7db73-9036-4a8f-8933-a6e221f8ba02)
Design
![Screenshot 2023-04-14 at 13.51.42.png](https://images.zenhubusercontent.com/61ef00ec5db2d7c84498dc72/d334fe58-19af-4e78-a8b2-5b9bca142df0)
[Storybook](https://output.circle-artifacts.com/output/job/cd8dc555-8cfd-4ea5-8fa0-c2c0f062550b/artifacts/0/storybook/index.html?path=/story/components-app-setapproveforallwarning--default-story)
[Figma ](https://www.figma.com/file/JgeDlRoz2b5xMxklSyHmbt/Token-allowances-(External)?node-id=2007%3A14561&t=mIwqOnpd1XUmqIro-1)

Contributor guide

Open the contributing guide

Research direction

Start with the SetApproveForAllWarning component through its Storybook story, `components-app-setapproveforallwarning--default-story`, and compare it with the linked design. Check the warning icon alignment and color, button spacing, secondary-button copy, and title. Done means the Storybook rendering matches the listed requirements and design.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.