MetaMask / MetaMask/metamask-extension

Show list of addresses with approval for NFTs with option to revoke them

Open
#17,655 1 comment 0 reactions 0 assignees View on GitHub
area-NFTs external-contributor INVALID-ISSUE-TEMPLATE team-assets
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

## Background
We have a proliferation of scams because users don't know who has approval rights to control their NFT assets. On the collectable details section we should create an allowances section showing who can approve and the right to revoke transactions. This feature would be about empowering users to be aware of which contracts, so they can better understand the current security parameters of their assets. For example, if they have an asset approved for Seaport, they need to be more alert against malicious signatures they are prompted to sign that would potentially leverage the approval to steal the asset.

## Acceptance Criteria
- Create an allowances section within the NFT collectible details
- Display a list of addresses that have approval to control the NFTs. We can call these `currently approved addresses`
- Create a button besides each to initiate revocation transaction

## Dependencies
This would require we find an NFT data indexer that can provide this data to check the contract on chain for approvals outside the context of a transaction.

Contributor guide

Open the contributing guide

Research direction

Start at the NFT collectible details section and investigate the dependency on an NFT data indexer that can expose approvals outside a transaction context. Determine how currently approved addresses can be retrieved and how revocation transactions should be initiated. Done means the section lists approved addresses and provides a revocation action beside each one.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
blockchain, frontend, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.