MetaMask / MetaMask/metamask-extension
Enhance how we fetch names for erc1155 contracts
Open
Nobody has claimed this yet.
area-NFTs
needs-triage
team-assets
type-enhancement
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
We should investigate and consider addressing these 2 situations where we currently fail to get a name for a NFT contract:
1. When name is only set in ERC1155 tokenUri
2. When contract uses a proxy (example here: https://etherscan.io/address/0x4bcb8a15af2c67e9a041eda4dd4a385dceffee39#code )
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the existing contract-name fetching path for ERC1155 tokens and inspect the linked Etherscan proxy example. Done means names are retrieved when they are defined only in an ERC1155 tokenURI and when the contract uses a proxy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100