MetaMask / MetaMask/metamask-extension
[Bug]: Import Wallet with Batch Accounts disabled loads all the Accounts that have ETH
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
### Describe the bug
**Problem**: if I Import a Wallet, while having the Batch Accounts feature disabled from the Onboarding flow, I expect to see only 1 Account, as there is no way that it knows how many Accounts should it load, if no batch request is sent?
https://user-images.githubusercontent.com/54408225/213661594-3564f1db-780d-4a30-bd6d-f9cbb3493ea8.mp4
### Steps to reproduce
1. Load MM for the first time
2. Import a Wallet (which you know it has more than 1 account with ETH)
3. Click Advanced Settings
4. Disable Batch Account requests
5. Proceed
6. Click Accounts dropdown -- see that there are loaded up to all accounts which have balance
### Error messages or log output
_No response_
### Version
10.24.0
### Build type
None
### Browser
Chrome
### Operating system
Linux
### Hardware wallet
_No response_
### Additional context
_No response_
Contributor guide
Research direction
Start with the wallet import and onboarding flow, following the Advanced Settings path where Batch Account requests are disabled. Reproduce the issue with an imported wallet containing multiple ETH-funded accounts; done means the Accounts dropdown shows only one account when batching is disabled.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100