MetaMask / MetaMask/metamask-extension

Refactor pages/confirm-transaction-base

Open
#17,247 0 comments 0 reactions 0 assignees View on GitHub
team-confirmations-planning type-refactor
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

Refactor https://github.com/MetaMask/metamask-extension/tree/develop/ui/pages/confirm-transaction-base is a huge and messy component. We need to refactor this:

1. make confirm-transaction-base.component.js functional component
2. add test coverage

Let's leave the container component in there for now as it is very complex. We will deprecate that in a following task.

Contributor guide

Open the contributing guide

Research direction

Start at ui/pages/confirm-transaction-base/confirm-transaction-base.component.js and inspect the component and nearby tests before changing it. Done means confirm-transaction-base.component.js is a functional component with added test coverage, while the complex container component remains in place.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.