MetaMask / MetaMask/metamask-extension

Delete confirm-transaction-switch component

Open
#17,236 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

team-confirmations-planning type-refactor
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

confirm-transaction-switch components is responsible for checking un-approved transaction / message and redirecting to appropriate confirmation route.

  1. Create a util method which will take transaction and return the pathname for confirmation route. Add test coverage for this method.

  2. use this method in /pages/confirm-transaction.component to redirect to specific confirmation route.

  3. Ensure this logic to get transaction id from url is also copied over to /pages/confirm-transaction.component

  4. Copy over test cases from pages/confirm-transaction-switch to /pages/confirm-transaction

  5. Delete pages/confirm-transaction-switch

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare pages/confirm-transaction-switch/confirm-transaction-switch.component.js and its test cases with /pages/confirm-transaction.component. Create and test the transaction-to-confirmation-path utility, move the transaction-id URL logic and tests to confirm-transaction, then remove pages/confirm-transaction-switch when the behavior is covered.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.