MetaMask / MetaMask/metamask-extension
production dependency contains 12.8 MB extraneous binary
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 13.2k
- Forks
- 5.6k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 451
Description
Describe the bug
The transitive runtime dependency ts-custom-error includes a >12MB extraneous binary in versions 2.1.0~3.1.0.
https://github.com/adriengibrat/ts-custom-error/issues/32
@zxing/library depends on ts-custom-error@^2.2.1 in versions 0.6.0-0.12.3. It upgrades to ^3.0.0 in 0.12.4-0.19.1 (current).
metamask-extension currently pin @zxing/library@0.8.0 since #12065, and apparently upgrading to a fixed version is a breaking change requiring refactoring existing code.
https://github.com/MetaMask/metamask-extension/pull/12065#discussion_r753600125
Steps to reproduce
yarn install --proddu -hs node_modules/ts-custom-error
Error messages or log output
No response
Version
develop
Build type
None
Browser
Other (please elaborate in the "Additional Context" section)
Operating system
Other (please elaborate in the "Additional Context" section)
Hardware wallet
No response
Additional context
The binary is not included in the final dist when building.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.