MetaMask / MetaMask/metamask-extension

Remove `lodash` submodules in favor of the "umbrella" package

Open
#16,536 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

epic MV3 team-extension-platform
Dominant language
TypeScript
Stars
13.2k
Forks
5.6k
Avg merge
2d 5h
Merged PRs (30d)
451

Description

Invesigate which (if any) of these submodules can be removed and replaced with the umbrella lodash package:

![Screen Shot 2022-11-16 at 1.39.46 PM.png](https://images.zenhubusercontent.com/612fcbe9f230e926789a2b4a/2c0c0d08-52e8-4ee4-9052-163f78fe2389)

The reason we want to remove submodules is because many of our dependencies use the umbrella `lodash` package and therefore we can't realistically hope to remove the umbrella package but can hopefully consolidate all instances of `lodash` through our dependency tree into one major version (without redundant submodules).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by auditing the project's dependency manifests and the lodash-related entries shown in the issue screenshot, then trace which packages require each submodule versus the umbrella package. Done means identifying removable submodules and consolidating the dependency tree where feasible; record any exceptions and validate the resulting dependency versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.